Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

only log all Req details for problematic requests #732

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Sep 20, 2017

not tested yet

@Dieterbe
Copy link
Contributor Author

tested it by inserting the following in the node.Post code, and comparing traces. it behaves as expected

+       rem := time.Now().Unix() % 10
+       if rem == 0 || rem == 1 || rem == 2 {
+               time.Sleep(11 * time.Second)
+       }
+

one thing worth noting is that with the cap at 45, the trace is only about 15kB, whereas we are allowed 65kB, so we cut a bit too aggressively. but i think it's ok, logging the first 45 entries should be a good tradeoff between usefulness and disk space usage.

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe Dieterbe merged commit 0d5baa8 into master Sep 26, 2017
@Dieterbe Dieterbe deleted the jaeger-control-verbosity branch September 18, 2018 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants