Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

first version of contribution guidelines #740

Merged
merged 1 commit into from
Oct 2, 2017
Merged

first version of contribution guidelines #740

merged 1 commit into from
Oct 2, 2017

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Oct 1, 2017

No description provided.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Oct 1, 2017

@shanson7 do you have thoughts on this?

Copy link
Contributor

@DanCech DanCech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanson7
Copy link
Collaborator

shanson7 commented Oct 1, 2017

Seems reasonable and easy enough to follow. What about linting / formatting code tools?

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Oct 1, 2017

good point, see new version.

@shanson7
Copy link
Collaborator

shanson7 commented Oct 1, 2017

LGTM

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Oct 2, 2017

thanks for the feedback guys. and feel free to always suggest changes or additions.

@Dieterbe Dieterbe merged commit 31a8e93 into master Oct 2, 2017
@Dieterbe Dieterbe deleted the contributing branch September 18, 2018 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants