This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
remove directory prefix when writing metric names #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Oct 5, 2017
| @@ -205,7 +205,7 @@ func getMetricName(file string) string { | |||
| file = file[1:] | |||
| } | |||
|
|
|||
| return *namePrefix + strings.Replace(strings.TrimSuffix(file, ".wsp"), "/", ".", -1) | |||
| return *namePrefix + strings.Replace(strings.TrimSuffix(strings.TrimPrefix(file, *whisperDirectory), ".wsp"), "/", ".", -1) | |||
There was a problem hiding this comment.
that's great.
is it possible that you'll need to take care of a potential leading / that's omitted in whisperDirectory?
like f.e. if the whisperDirectory is /opt/storage and the file is /opt/storage/mypath/abc.wsp then we'll want mypath/abc.wsp and not /mypath/abc.wsp right?
There was a problem hiding this comment.
Yea, that's definitely an issue, since there could be a . prefixing the name
https://play.golang.org/p/lLZtHioeJO
|
fix #731 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the importer-reader tool that removes the whisper directory flag from the metric name.