Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

fix anchoring #749

Merged
merged 1 commit into from
Oct 16, 2017
Merged

fix anchoring #749

merged 1 commit into from
Oct 16, 2017

Conversation

replay
Copy link
Contributor

@replay replay commented Oct 16, 2017

@replay replay merged commit 116c2f7 into master Oct 16, 2017
@shanson7
Copy link
Collaborator

nitpicky, but this should probably be a non-capturing group.

@DanCech
Copy link
Contributor

DanCech commented Oct 16, 2017

Not sure if it matters since we only use it with MatchString, I guess a non-capturing group might save a tiny amount inside the regex lib but I couldn't say either way.

@Dieterbe Dieterbe deleted the fix_anchoring branch September 18, 2018 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanCech DanCech DanCech approved these changes

@Dieterbe Dieterbe Awaiting requested review from Dieterbe

@woodsaj woodsaj Awaiting requested review from woodsaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@replay @shanson7 @DanCech