This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Tag api endpoints #750
Merged
Tag api endpoints #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
force-pushed
the
tag_api_endpoints
branch
8 times, most recently
from
ef0b363
to
c1bfb2c
Compare
|
@Dieterbe i think all the comments have either been replied to or the requests/suggestions have been added |
Dieterbe
reviewed
Oct 24, 2017
api/models/node.go
Outdated
| type IndexTagDetails struct { | ||
| OrgId int `json:"orgId" binding:"Required"` | ||
| Filter string `json:"filter"` | ||
| Tag string `json:"tag"` |
There was a problem hiding this comment.
are empty tag keys legal? otherwise add binding:"Required" here
There was a problem hiding this comment.
you're right, that should be required f3bd367
replay
force-pushed
the
tag_api_endpoints
branch
from
664d425
to
df646b2
Compare
replay
force-pushed
the
tag_api_endpoints
branch
3 times, most recently
from
207a77f
to
d4dfc37
Compare
replay
force-pushed
the
tag_api_endpoints
branch
from
d4dfc37
to
01a8c7e
Compare
|
in case you missed it: #750 (comment) |
Dieterbe
approved these changes
Nov 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the API endpoints for:
/tags(with optionalfilter)/tags/<tag>(with optionalfilter)/tags/findSeries(with list ofexpr)The goal is that the API is exactly the same like documented in the graphite docs: http://graphite.readthedocs.io/en/latest/tags.html#querying
The
prettyparameter has been ignored for now.I think that once we change the main index to use the numeric
idx.MetricIDtype instead ofstrings then the performance fo calls like/tags/<tag>might improve, because they rely heavily on ID lookups in the main index.