This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix mt-store-cat nilpointer #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the provided context must contain a span panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7d3c2d] goroutine 1 [running]: github.com/raintank/metrictank/tracing.NewSpan(0xc94ec0, 0xc4200d6008, 0xc94680, 0xce80f0, 0xa0e4c5, 0x1a, 0x4bd0d3, 0x989da0, 0xc420fa2220, 0x99) /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/tracing/tracing.go:19 +0x6d github.com/raintank/metrictank/mdata.(*CassandraStore).SearchTable(0xc42046e1e0, 0xc94ec0, 0xc4200d6008, 0xc420a0fb90, 0x26, 0xc4205b82a0, 0x9, 0x5a0349e65a01f866, 0x0, 0x0, ...) /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/mdata/store_cassandra.go:416 +0xce main.points(0xc42046e1e0, 0xc4201e4380, 0x5, 0x8, 0xc4209a9780, 0x1, 0x1, 0x5a0349e65a01f866, 0x0) /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/cmd/mt-store-cat/series.go:25 +0x3c6 main.main() /home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/cmd/mt-store-cat/main.go:251 +0x15b7
Dieterbe
force-pushed
the
fix-mt-store-cat
branch
from
d4a5608
to
33c84d7
Compare
replay
reviewed
Nov 9, 2017
| @@ -9,7 +10,7 @@ import ( | |||
| "github.com/grafana/metrictank/mdata" | |||
| ) | |||
|
|
|||
| func chunkSummary(store *mdata.CassandraStore, tables []string, metrics []Metric, keyspace, groupTTL string) error { | |||
| func chunkSummary(ctx context.Context, store *mdata.CassandraStore, tables []string, metrics []Metric, keyspace, groupTTL string) error { | |||
There was a problem hiding this comment.
that ctx doesn't seem to be used
There was a problem hiding this comment.
for consistency, all these functions that go out and collect and print data get a context arg
replay
reviewed
Nov 9, 2017
| @@ -247,12 +256,15 @@ func main() { | |||
|
|
|||
| fmt.Printf("# Keyspace %q:\n", *cassandraKeyspace) | |||
|
|
|||
| span := tracer.StartSpan("mt-store-cat " + format) | |||
There was a problem hiding this comment.
isn't the only purpose of initializing the tracer just to prevent stuff from calling methods on a nil value? why bother starting a span then?
There was a problem hiding this comment.
the span needs to be non-nil otherwise we get a panic.
plus also i envision at some point we'll actually start collecting traces from this tool.
|
ok, that looks good to me. shall i merge? |
|
Yes please or approve it thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the provided context must contain a span
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7d3c2d]
goroutine 1 [running]:
github.com/raintank/metrictank/tracing.NewSpan(0xc94ec0, 0xc4200d6008, 0xc94680, 0xce80f0, 0xa0e4c5, 0x1a, 0x4bd0d3, 0x989da0, 0xc420fa2220, 0x99)
/home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/tracing/tracing.go:19 +0x6d
github.com/raintank/metrictank/mdata.(*CassandraStore).SearchTable(0xc42046e1e0, 0xc94ec0, 0xc4200d6008, 0xc420a0fb90, 0x26, 0xc4205b82a0, 0x9, 0x5a0349e65a01f866, 0x0, 0x0, ...)
/home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/mdata/store_cassandra.go:416 +0xce
main.points(0xc42046e1e0, 0xc4201e4380, 0x5, 0x8, 0xc4209a9780, 0x1, 0x1, 0x5a0349e65a01f866, 0x0)
/home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/cmd/mt-store-cat/series.go:25 +0x3c6
main.main()
/home/ubuntu/.go_workspace/src/github.com/raintank/metrictank/cmd/mt-store-cat/main.go:251 +0x15b7