This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Feature fix name tag regex #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/grafana/metrictank/pull/762/files?w=1 has a cleaner view of the changes (hides whitespace) |
|
can you update the commit message to convey what exactly the problem is that this solves. |
shanson7
force-pushed
the
feature_fix_name_tag_regex
branch
from
36ce958
to
a484352
Compare
|
Message updated. |
|
thanks @shanson7 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a corner case recently added with the special
nametag.