This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
remove from adjustment for clustered requests #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was already removed for local requests via 4fbf1b7 but we also need to remove it for cluster requests otherwise data returned is inconsistent upon subsequent requests to different cluster nodes, which can result in all kinds of problems
|
this mostly fixes #380 except for the query example that awoods outlined. but we can create a new ticket for how to handle that |
woodsaj
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was already removed for local requests via
4fbf1b7
but we also need to remove it for cluster requests
otherwise data returned is inconsistent upon subsequent
requests to different cluster nodes, which can result
in all kinds of problems