This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Rm old mt index tools and mt-replicator #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.7.0 was relased feb 7, 2017 https://github.com/grafana/metrictank/releases/tag/0.7.0 we no longer support anything before that
mt-replicator uses the sarama-cluster for distributing partitions between instances and tracking offsets but it does not work reliably. We have tried to use mt-replicator before and it regularly just stops consuming from some partitions.
Dieterbe
changed the title
using something like rsync -au --delete would be nicer but i don't want to assume we have rsync available in CI.
replay
reviewed
Dec 14, 2017
scripts/check_docs_uptodate.sh
Outdated
| ./config-to-doc.sh > $tmp | ||
| diff ../docs/config.md $tmp | ||
|
|
||
| # metrics2docs .> docs/metrics.md this doesn't work very well yet |
replay
reviewed
Dec 14, 2017
| exit 2 | ||
| fi | ||
| ./config-to-doc.sh > $tmp | ||
| diff ../docs/config.md $tmp |
There was a problem hiding this comment.
did you mean $tmp removal also here?
There was a problem hiding this comment.
it doesn't do anything with the returned value. or is it supposed to just output the diff and nothing else?
There was a problem hiding this comment.
it outputs the diff, if any, and the script exits with the exit code of the diff command, so that we can verify it. but to your point, i will add the rm $tmp which requires adding the explicit exiting with diff's exit code (which currently is not obvious to the reader)
|
@replay fixed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect the new scripts/check_docs_uptodate.sh will break the build, because we have a lot of accumulated out-of-date-ness (unrelated to this PR) that we have to address