Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

add flag to import data only after a certain timestamp #793

Merged
merged 2 commits into from
Dec 20, 2017
Merged

add flag to import data only after a certain timestamp #793

merged 2 commits into from
Dec 20, 2017

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Dec 19, 2017

Some imports require a more specific time range. This allows us to specify a range rather than an upper timestamp for imports.

@jtlisi jtlisi requested a review from replay December 19, 2017 18:57
@replay
Copy link
Contributor

replay commented Dec 20, 2017

in that for loop in decResolution() you might also want to continue if the timestamp is below importAfter

replay
replay approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtlisi jtlisi merged commit 4f79e0d into master Dec 20, 2017
@jtlisi jtlisi deleted the import-after-flag branch December 20, 2017 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@replay replay replay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtlisi @replay