Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

split up circleCI jobs into parallel workflows #810

Merged
merged 4 commits into from
Jan 23, 2018
Merged

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Jan 3, 2018

continuation of #803

@Dieterbe Dieterbe force-pushed the circle-workflows branch 5 times, most recently from 4af33db to 7434db9 Compare January 3, 2018 18:51
@DanCech DanCech changed the title WIP: split up circleCI jobs into parrallel workflows WIP: split up circleCI jobs into parallel workflows Jan 3, 2018
@Dieterbe Dieterbe force-pushed the circle-workflows branch 4 times, most recently from f37f82d to b173d6a Compare January 3, 2018 20:00
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Jan 3, 2018

this workflow stuff in circleCI is neat. CI build time from 18 min to 6min

click on the green checkmark to see individual workflows, from there going to the workflow overview is a bit trickier, but here's the link for your convenience : https://circleci.com/workflow-run/a9e3cbc0-2925-4a9c-9c28-594faa778218

@Dieterbe Dieterbe changed the title WIP: split up circleCI jobs into parallel workflows split up circleCI jobs into parallel workflows Jan 3, 2018
@Dieterbe Dieterbe force-pushed the circle-workflows branch 5 times, most recently from 71cd305 to 0aeda5f Compare January 3, 2018 22:55
@Dieterbe Dieterbe requested a review from woodsaj January 3, 2018 23:01
Copy link
Contributor

@DanCech DanCech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

Copy link
Member

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont test or publish the docker image.
The docker image created in the build step wont be available in the qa-post-build step and also want be available in the deploy step. The end2end test will just pull down the latest image from dockerhub, and the deploy step will fail.

I suggest that after you build the docker image you use
docker save to write the image to a tarball in the buil dir. Then in the other steps use docker import to load it into the local docker instance.

- run: scripts/build_tools.sh
- setup_remote_docker
- run: scripts/build_docker.sh
- run: mkdir build_docker && docker save -o build_docker/metrictank.tar metrictank
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image is "grafana/metrictank" not "metrictank"

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Jan 4, 2018

i still need to make sure the tags are re-instated properly, will circle back (no pun intented) after i'm done with some more pressing work

@Dieterbe Dieterbe mentioned this pull request Jan 5, 2018
because we need ruby stuff, not go stuff

note:
- ruby 2.3 because json library that fpm seemingly wants to use
  doesn't work with 2.4 (flori/json#303)
- for some reason apt-get update no longer needed
@Dieterbe
Copy link
Contributor Author

@woodsaj mergey mergey?

steps:
- checkout
- attach_workspace:
at: build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be at: . otherwise you will end up with build/builld/metrictank

@Dieterbe Dieterbe merged commit 90fa7ed into master Jan 23, 2018
@Dieterbe Dieterbe deleted the circle-workflows branch September 18, 2018 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants