-
Notifications
You must be signed in to change notification settings - Fork 104
split up circleCI jobs into parallel workflows #810
Conversation
4af33db
to
7434db9
Compare
f37f82d
to
b173d6a
Compare
this workflow stuff in circleCI is neat. CI build time from 18 min to 6min click on the green checkmark to see individual workflows, from there going to the workflow overview is a bit trickier, but here's the link for your convenience : https://circleci.com/workflow-run/a9e3cbc0-2925-4a9c-9c28-594faa778218 |
71cd305
to
0aeda5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wont test or publish the docker image.
The docker image created in the build step wont be available in the qa-post-build step and also want be available in the deploy step. The end2end test will just pull down the latest image from dockerhub, and the deploy step will fail.
I suggest that after you build the docker image you use
docker save
to write the image to a tarball in the buil dir. Then in the other steps use docker import
to load it into the local docker instance.
.circleci/config.yml
Outdated
- run: scripts/build_tools.sh | ||
- setup_remote_docker | ||
- run: scripts/build_docker.sh | ||
- run: mkdir build_docker && docker save -o build_docker/metrictank.tar metrictank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image is "grafana/metrictank" not "metrictank"
7cd44e2
to
b0b6833
Compare
i still need to make sure the tags are re-instated properly, will circle back (no pun intented) after i'm done with some more pressing work |
because we need ruby stuff, not go stuff note: - ruby 2.3 because json library that fpm seemingly wants to use doesn't work with 2.4 (flori/json#303) - for some reason apt-get update no longer needed
b0b6833
to
17e973a
Compare
@woodsaj mergey mergey? |
.circleci/config.yml
Outdated
steps: | ||
- checkout | ||
- attach_workspace: | ||
at: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be at: .
otherwise you will end up with build/builld/metrictank
continuation of #803