Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

only prune metrics where all MDs of name are stale #816

Merged
merged 2 commits into from
Jan 10, 2018

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 10, 2018

modifies the index loading so only names/tagSets are pruned where all MetricDefinitions are Stale.

@replay replay force-pushed the dont_drop_used_metrics_on_start branch from 987202a to e87d882 Compare January 10, 2018 12:50
modifies the index loading so only names/tagSets are pruned
where all MetricDefinitions are Stale.

fixes #813
@replay replay force-pushed the dont_drop_used_metrics_on_start branch from e87d882 to 8ab44f3 Compare January 10, 2018 12:53
@replay replay force-pushed the dont_drop_used_metrics_on_start branch from 7ecff7c to c50e8e7 Compare January 10, 2018 14:33
@replay replay changed the title [WIP] only prune metrics where all MDs of name are stale only prune metrics where all MDs of name are stale Jan 10, 2018
Copy link
Member

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe
Copy link
Contributor

nice unit tests 👍

@Dieterbe Dieterbe merged commit 7ff0845 into master Jan 10, 2018
@Dieterbe Dieterbe deleted the dont_drop_used_metrics_on_start branch September 18, 2018 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants