This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
mt-index-cat tags valid filter #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
mt-index-cat-tags-valid-filter
branch
from
dc1a377
to
8ede421
Compare
Dieterbe
force-pushed
the
mt-index-cat-tags-valid-filter
branch
from
2e9eb03
to
b8f494d
Compare
replay
reviewed
Jan 11, 2018
cmd/mt-index-cat/main.go
Outdated
| @@ -157,6 +172,22 @@ func main() { | |||
| for _, d := range defs { | |||
| if prefix == "" || strings.HasPrefix(d.Metric, prefix) { | |||
| if substr == "" || strings.Contains(d.Metric, substr) { | |||
| if tags != "" { | |||
There was a problem hiding this comment.
unimportant: the above two ifs could also be inverted and result in continue if true, just to reduce the number of nested blocks
There was a problem hiding this comment.
yep, adjusted. looks better now!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if approved, i'll port the changes to schema lib also of course.