This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Init Logger before Configs #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project attempts to use the logger before it's initialized. For example, it would never print out log.Fatal(4, "error with configuration file: %s", err) and merely exit. Additionally the logger is used in loading configs meaning they silently fail. The user specified logging levels are applied after configs are parsed. golang's init function runs first so log-level will be parsed already
Dieterbe
approved these changes
Jan 22, 2018
Merged
beorn-
pushed a commit
to beorn-/metrictank
that referenced
this pull request
Nov 27, 2018
as of grafana#823/grafana#825, the logger was created before flags were parsed and the config (file and env vars) were loaded. so the logger would always get the default value for the flag and no way to change the level.. I tried creating the logger after flag parsing, and adjusting the log level after config parsing, but couldn't the second step to work properly. Simplest solution is to just print to stderr directly the one time we actually need it in between the two steps. PS: I hate this logging library, but we'll get rid of it. see grafana#624
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project attempts to use the logger before it's initialized.
For example, it would never print out log.Fatal(4, "error with configuration file: %s", err) and merely exit. Additionally the logger is used in loading configs meaning they silently fail.
The user specified logging levels are applied after configs are parsed.
golang's init function runs first so log-level will be parsed already