Add support for sortByName
#827
Conversation
hmm that was specifically added because that's how graphite did it. was that a mistake or has graphite changed since then? ( 0d67756 ) |
|
Hmm, maybe sorting results gets disabled if a |
|
Seems like an unrelated test failed. I have seen this test fail on me a couple of times, transiently. |
|
@DanCech - Can you comment on the sorting of graphite-web? I'm trying to look through the code, but I'm not sure where that's handled |
|
The series that come back from any data query are sorted by name here, running them through |
|
Ah, so they are ordered before functions are run on them? |
|
Yessir |
|
And now metrictank matches graphite in it's presort. |
| ) | ||
|
|
||
| func shuffleSeries(slice []string) { | ||
| for i := len(slice) - 1; i > 0; i-- { |
There was a problem hiding this comment.
why count down instead of the more commonly used count up?
There was a problem hiding this comment.
This is the most common version of the Fisher-Yates algorithm. The alternative is from 0 to len-2. I don't really care which one to use.
|
thanks for another nice contribution @shanson7 ! 💯 |
Also removes the automatic sorting of output by series target in
plan.go.