This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
build metrictank-gcr docker image automatically in MT repo #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
reviewed
Jan 25, 2018
.circleci/config.yml
Outdated
| @@ -60,6 +60,7 @@ jobs: | |||
| at: . | |||
| - run: scripts/depends.sh | |||
| - run: scripts/build_packages.sh | |||
| - run: echo ${GOOGLE_AUTH} > ${HOME}/gcp-key.json | |||
There was a problem hiding this comment.
this is not needed. In scripts/push/gcr.sh you are just loading the contents of this file back into an ENV var.
in scripts/push/gcr.sh just use ${GOOGLE_AUTH} directly.
There was a problem hiding this comment.
ok we can do that, as long as we make sure to never add set -x in the script. (which i took out now)
|
@replay @woodsaj please have another look. |
woodsaj
approved these changes
Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.