Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Add support for divideSeriesLists #833

Merged
merged 4 commits into from
Jan 30, 2018

Conversation

shanson7
Copy link
Collaborator

No description provided.

@Dieterbe
Copy link
Contributor

do you think it would make sense to use the same implementation supporting both divideSeries and divideSeriesLists ? from the docs, looks like the only difference is whether the divisor is a single series or not. (i'm not saying that would be the better way, i'm happy to merge whichever approach you think is better)

@shanson7
Copy link
Collaborator Author

I did think about that, but was worried that handling the validation would get a little messy. Let me quickly mock up the approach and see what it looks like.

@Dieterbe
Copy link
Contributor

yeah that was also my concern. sometimes it's better to have more code if it's simpler.
anyway don't spend too much time on that, i was more thinking out loud than anything.

@shanson7
Copy link
Collaborator Author

The logic to support iterating over the divisors in the list case is a little annoying, but the actual division and series creation stuff could be factored out into a shared implementation. I'm not sure where the best place to stick that would be.

@Dieterbe Dieterbe merged commit 7955111 into grafana:master Jan 30, 2018
@Aergonus Aergonus deleted the feature_divideSeriesLists branch May 7, 2018 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants