Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Speculative execution fixes #979

Merged
merged 6 commits into from
Aug 7, 2018
Merged

Speculative execution fixes #979

merged 6 commits into from
Aug 7, 2018

Commits on Aug 6, 2018

  1. clarify

    Dieterbe committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    e3c47c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. implement speculation-threshold by its spec

    spec says:
    ```
    ratio of peer responses after which speculation is used. Set to 1 to disable.
    speculation-threshold = 1
    ```
    
    However, code would only trigger after *more* than the threshold is met.
    
    example:
    4 shardgroups.
    threshold = 0.75
    imagine after 3 shardgroups have returned, you would expect the
    speculation to kick in.
    
    However, the logic would flow like this:
    
    percentReceived = 1 - (1/4) = 3/4 = 0.75
    if percentReceived > speculationThreshold then speculate
    if 0.75 > 0.75 -> no speculation!.
    
    It would wait until another shard returns (in this case, until all shard
    groups return)
    
    also if threshold=1, bypass speculation logic more explicitly
    Dieterbe committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    af8923b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d06e78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbb9bf6 View commit details
    Browse the repository at this point in the history
  4. doc fixes

    Dieterbe committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    6690299 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3428869 View commit details
    Browse the repository at this point in the history