Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with prometheus: enable errorf rule from perfsprint linter #777

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

colega
Copy link
Contributor

@colega colega commented Dec 2, 2024

Follow up update after #772

This PR brings the commit enable errorf rule from perfsprint linter · prometheus/prometheus@af1a19f from Prometheus, which changes a fmt.Errorf call in 64 files, so sending it as a separate PR for easier review.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ colega
❌ mmorel-35
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@colega colega merged commit 9275862 into main Dec 2, 2024
9 of 10 checks passed
@colega colega deleted the prometheus-af1a19f branch December 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants