fix(remote-read): return err instead of nil (#3053)

Signed-off-by: Furkan <furkan.turkal@trendyol.com> Signed-off-by: Furkan <furkan.turkal@trendyol.com>
grafana · Sep 27, 2022 · 44bd7bc · 44bd7bc
1 parent 3dee1a4
commit 44bd7bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -45,6 +45,8 @@
 
 ### Mimirtool
 
+* [BUGFIX] mimir-tool remote-read: fix returns where some conditions [return nil error even if there is error](https://github.com/grafana/cortex-tools/issues/260). #3053
+
 ### Query-tee
 
 ### Mimir Continuous Test

diff --git a/pkg/mimirtool/commands/remote_read.go b/pkg/mimirtool/commands/remote_read.go
@@ -276,7 +276,7 @@ func (c *RemoteReadCommand) dump(k *kingpin.ParseContext) error {
 
 	timeseries, err := query(context.Background())
 	if err != nil {
-		return nil
+		return err
 	}
 
 	iterator := newTimeSeriesIterator(timeseries)
@@ -309,7 +309,7 @@ func (c *RemoteReadCommand) stats(k *kingpin.ParseContext) error {
 
 	timeseries, err := query(context.Background())
 	if err != nil {
-		return nil
+		return err
 	}
 
 	num := struct {