ingester: Improve error message when thanos.shipper.json is invalid #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
changed the title
aknuds1
force-pushed
the
chore/improve-shipper-read-meta
branch
2 times, most recently
from
b96d7bf to
b83b838
Compare
colega
approved these changes
Feb 21, 2022
|
Maybe it's worth upstreaming this change to Thanos and leaving a TODO here to update once it's merged there? |
@colega could be - I'm also unsure if we want to keep depending on Thanos in the future? |
|
I don't know 🤷 |
aknuds1
force-pushed
the
chore/improve-shipper-read-meta
branch
from
b83b838 to
34dd389
Compare
|
Converting PR to draft, since I've made an upstream PR instead and consensus is to wait for upstream to review. |
|
This is a copy-paste message. I've just cut the CHANGELOG in preparation to Mimir 2.0.0 release. Could you rebase |
Return a more descriptive error message when the ingester fails to update cached shipped blocks due to thanos.shipper.json containing invalid JSON. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/improve-shipper-read-meta
branch
from
34dd389 to
d4fb463
Compare
|
Closing this since upstream PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Return a more descriptive error message when the ingester fails to update cached shipped blocks due to thanos.shipper.json containing invalid JSON. Also adding tests.
Which issue(s) this PR fixes
Fixes #1241.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]