Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc add tenant-federation in authentication-and-authorization #1689

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

kehao95
Copy link
Contributor

@kehao95 kehao95 commented Apr 12, 2022

What this PR does

Add how tenant-federation works in Doc's authentication and authorization

Which issue(s) this PR fixes or relates to

#1635

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2022

CLA assistant check
All committers have signed the CLA.

@56quarters 56quarters added the type/docs Improvements or additions to documentation label Apr 12, 2022
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'll let our docs people weigh in. Thanks!

@chri2547 chri2547 removed their request for review April 12, 2022 15:59
@kehao95 kehao95 force-pushed the main branch 2 times, most recently from 818a15a to dfc9046 Compare April 12, 2022 22:18
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM (modulo a nit)

Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed verbiage to speak more directly to the reader.

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Nick Pillitteri <nick@56quarters.xyz>
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci dismissed osg-grafana’s stale review April 13, 2022 16:38

Ursula feedback has been addressed, so going to merge.

@pracucci pracucci merged commit de01877 into grafana:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants