Allow custom data source in mixin dashboards. #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarp
force-pushed
the
custom-datasource
branch
from
c424eee to
7b3d82a
Compare
pstibrany
approved these changes
Apr 22, 2022
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## Grafana Mimir - main / unreleased | |||
|
|
|||
| * [ENHANCEMENT] Dashboards: Allow custom datasources. #1605 | |||
There was a problem hiding this comment.
Please move this under "Jsonnet" section.
There was a problem hiding this comment.
Moved to the mixin section, since that seemed to be the place where other dashboard updates are tracked.
There was a problem hiding this comment.
You're right, thank you. Can you please fix the [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX] order? :)
jmcarp
force-pushed
the
custom-datasource
branch
2 times, most recently
from
8a8403a to
d704dd2
Compare
Adapted from grafana/cortex-jsonnet#407. Signed-off-by: Josh Carp <jm.carp@gmail.com>
jmcarp
force-pushed
the
custom-datasource
branch
from
d704dd2 to
ca4c164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This restores a tiny change from cortex-jsonnet to allow custom datasources for compiled dashboards: grafana/cortex-jsonnet#407.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]