Enforce parity between Jsonnet and Helm #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logiraptor
force-pushed
the
logiraptor/use-k8s-diff
branch
2 times, most recently
from
b176096 to
328d307
Compare
Logiraptor
force-pushed
the
logiraptor/use-k8s-diff
branch
2 times, most recently
from
0368970 to
6778644
Compare
Logiraptor
changed the title
Logiraptor
force-pushed
the
logiraptor/use-k8s-diff
branch
2 times, most recently
from
1346d82 to
535f176
Compare
Logiraptor
force-pushed
the
logiraptor/use-k8s-diff
branch
from
7ae9392 to
e9eba30
Compare
operations/compare-helm-with-jsonnet/plugins/resolve-config/full-input.yaml
Outdated
Show resolved
Hide resolved
Logiraptor
force-pushed
the
logiraptor/use-k8s-diff
branch
from
b3733ce to
8806d5f
Compare
This was referenced Jun 23, 2022
dimitarvdimitrov
approved these changes
Jun 24, 2022
operations/compare-helm-with-jsonnet/helm/03-set-namespace/kustomization.yaml
Outdated
Show resolved
Hide resolved
operations/compare-helm-with-jsonnet/helm/06-services/kustomization.yaml
Outdated
Show resolved
Hide resolved
| metadata: | ||
| name: mimir-config | ||
|
|
||
| # TODO(logiraptor): Helm adds a grpc port to the overrides exporter, Jsonnet does not. |
There was a problem hiding this comment.
Are you calling dibs on all the TODOs? /s
operations/compare-helm-with-jsonnet/plugins/resolve-config/main.go
Outdated
Show resolved
Hide resolved
Comment on lines
+202
to
+205
| flagSet.Bool("config.expand-env", false, "") | ||
| flagSet.Int("mem-ballast-size-bytes", 0, "") |
There was a problem hiding this comment.
Why are these two needed?
There was a problem hiding this comment.
Added a comment to help explain. It's a little hacky tbh. Basically these are the only two used in either jsonnet or helm that aren't defined in the configuration struct.
operations/compare-helm-with-jsonnet/plugins/resolve-config/main_test.go
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Jul 13, 2022
krajorama
force-pushed
the
logiraptor/use-k8s-diff
branch
from
ce8860e to
6e100d8
Compare
|
trivial rebase |
krajorama
reviewed
Jul 21, 2022
operations/compare-helm-with-jsonnet/helm/06-pods/kustomization.yaml
Outdated
Show resolved
Hide resolved
operations/compare-helm-with-jsonnet/helm/06-pods/kustomization.yaml
Outdated
Show resolved
Hide resolved
operations/compare-helm-with-jsonnet/helm/06-pods/kustomization.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
|
Helm <> Jsonnet Diff 🎉 No differences where detected between Helm and Jsonnet 🎉 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use kustomize to compare Jsonnet with Helm automatically.
See the section in docs for more information.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]