New S3 Flag to configure ListObjectsVersion #5099
Conversation
|
|
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
This patch make it possible to configure the S3 ListObjectsVersion, which is already configurable in the [thanos-io S3 Client](https://github.com/thanos-io/objstore/blob/23ebe2eacadd89cf23bf0fbd931352112b4c846d/providers/s3/s3.go#LL137C47-L137C67). Signed-off-by: Sven Haardiek <sven@haardiek.de>
shaardie
force-pushed
the
s3-list-objects-version
branch
from
dec4225 to
28815f7
Compare
Done. |
This patch adds the suggestions from the PR Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
|
Looks like the docs need to be regenerated based on the CLI flag change. |
Signed-off-by: Sven Haardiek <sven@haardiek.de>
Done and great that this can be merged! |
This patch make it possible to configure the S3 ListObjectsVersion, which is already configurable in the thanos-io S3 Client.
What this PR does
This PR introduce a new configuration flag
-<prefix>.s3.list-objects-versionto be able to configure the used S3 ListObjectsVersion as already possible in the underlying thanos-io S3 Client.This helps, e.g. with older versions from Ceph, which only give 1000 Objects, if this is not configured to
v1.Which issue(s) this PR fixes or relates to
No issue for this, I directly created this Pull Request.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]