Docs: clarify ingester_stream_chunks_when_using_blocks setting #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
approved these changes
Aug 28, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
pracucci
force-pushed
the
doc-improve-chunk-streaming
branch
from
fe01739 to
7e33309
Compare
pstibrany
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
After an internal conversation at Grafana Labs, we realised there's some misunderstanding around the
ingester_stream_chunks_when_using_blocksnote in the doc. In this PR I'm rephrasing based on a feedback received from @bboreham.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]