Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-changelog.sh: ignore certain paths #5852

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

colega
Copy link
Contributor

@colega colega commented Aug 29, 2023

What this PR does

Makes check-changelog.sh ignore certain paths:

  • Integration tests are never user-facing changes
  • Helm has its own changelog
  • CHANGELOG.md are not user-facing
  • Docs describe what we're shipping

This reduces the number of PRs to review for 2.10 from 270 to 200.

Which issue(s) this PR fixes or relates to

Ref: Release 2.10

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

- Integration tests are never user-facing changes
- Helm has its own changelog
- CHANGELOG.md are not user-facing
- Docs describe what we're shipping

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega requested a review from a team as a code owner August 29, 2023 07:56
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy solution. LGTM. I was wondering if we want to exclude "docs" but I can also see we have many PRs doing very small changes to doc which is probably not even worth to mention in the CHANGELOG.

@colega colega enabled auto-merge (squash) August 29, 2023 08:43
@colega colega merged commit e5bc55f into main Aug 29, 2023
@colega colega deleted the ignore-certain-paths-for-check-changelog branch August 29, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants