-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of tenant federation concurrency #5874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the max number of per-tenant queries run concurrently to be configured when executing a multi-tenant query. This can help mitigate performance issues when running queries across more than 16 tenants at once. Fixes #2715 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/federation-concurrency
branch
from
August 30, 2023 16:11
38860f5
to
81adb3a
Compare
pstibrany
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should mention new experimental flag in about-versioning.md file too.
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
grafanabot
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Allow configuration of tenant federation concurrency Allow the max number of per-tenant queries run concurrently to be configured when executing a multi-tenant query. This can help mitigate performance issues when running queries across more than 16 tenants at once. Fixes #2715 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Note about new experimental option in docs Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d19de08)
Backport action failed because of github credentials rate limit, and it couldn't leave a comment here for same reason 🤦 I'm going to create it manually. |
Created: #5900 |
colega
added a commit
that referenced
this pull request
Sep 1, 2023
…5874) (#5900) * Allow configuration of tenant federation concurrency (#5874) * Allow configuration of tenant federation concurrency Allow the max number of per-tenant queries run concurrently to be configured when executing a multi-tenant query. This can help mitigate performance issues when running queries across more than 16 tenants at once. Fixes #2715 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Note about new experimental option in docs Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> (cherry picked from commit d19de08) * Move CHANGELOG.md entry to rc.1 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Allow the max number of per-tenant queries run concurrently to be configured when executing a multi-tenant query. This can help mitigate performance issues when running queries across more than 16 tenants at once.
Which issue(s) this PR fixes or relates to
Fixes #2715
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]