-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing cortextool from separate repo cortex-tools #708
Conversation
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…ool -> cortex-cli Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…_deleting_tool add chunk-tool with initial delete function
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…elete_series_functionality add delete series command
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…olumns Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
…_series_deletion 20190812 label series deletion, merging to get instrumentation
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
I think I have addressed most issues that have arisen:
The ones remaining are:
|
cmd/cortextool/.goreleaser.yml
Outdated
@@ -0,0 +1,152 @@ | |||
before: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we wanna keep using it? I didn't have a very nice experience with that. I'm wondering if we can release using Mimir tooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not found to many issues when releasing, but I think we should have something that is run in a more automated fashion than cortex-tools had.
I think we should address this in a separate PR and have created #747
@@ -0,0 +1,199 @@ | |||
package analyse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move cmd/cortextool/pkg
to pkg/cortextool
(or whatever the name will be)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to deffer that to the time when we have a name.
0931460
to
ecbe10b
Compare
ecbe10b
to
bbf53f4
Compare
I think it makes sense to merge this state and work on the remaining work in separate PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to merge this state and work on the remaining work in separate PRs:
I agree. Could you rebase to fix confclits, so we can merge, please?
It is already part of mimir
Integrate additional exlude from cortextool and sort lines.
bbf53f4
to
c38f9a3
Compare
This PR must be merged WITHOUT squashing (just a merge commit). |
This is an automated import of the https://github.com/grafana/cortex-tools repo.
For preparing the remote repo this script was used:
This fixes https://github.com/grafana/mimir-squad/issues/437