Helm: use mimir continuous test as module #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smoke-test: remove the `continuous_test.image` section and reuse the main Mimir image from the top `image` section using the new `-target=continuous-test` CLI flag. This fixes CI errors due to missing -server.metrics-port CLI flag as well. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
| args: | ||
| - "-target=continuous-test" | ||
| - "-activity-tracker.filepath=/active-query-tracker/activity.log" |
There was a problem hiding this comment.
do we need that? isn't this also the default in the yaml config?
There was a problem hiding this comment.
same applies to the continuous-test job
There was a problem hiding this comment.
These don't use the config file, which is I think fine , they need to be somewhat independent observers. As discussed , I'm trying to instead disable the tracker by setting the path to empty.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use continuous test as a target of the mimir image instead of standalone image.
Simplifies the release process.
Which issue(s) this PR fixes or relates to
Related to #7747
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.