Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir query engine: complete renaming from #8256 #8348

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jun 12, 2024

What this PR does

While making use of RegisterInstantVectorFunctionOperator in an internal project, I noticed that we didn't completely rename everything to include the word "factory" where appropriate.

This PR clarifies those names.

Which issue(s) this PR fixes or relates to

#8256

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review June 12, 2024 05:25
@charleskorn charleskorn requested a review from a team as a code owner June 12, 2024 05:25
@charleskorn charleskorn enabled auto-merge (squash) June 12, 2024 05:26
@charleskorn charleskorn merged commit b9e766b into main Jun 12, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/fix-names branch June 12, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants