Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compactor in target=all. Update single binary documentation and examples to enable compactor sharding #866

Merged
merged 6 commits into from
Jan 25, 2022

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Jan 24, 2022

Which issue(s) this PR fixes: This PR enables compactor in single-binary mode. It also updates getting-started documentation and examples to enable compactor sharding. Warning is now logged when user starts compactor with sharding disabled.

Part of #814.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for answering my questions

@pstibrany pstibrany force-pushed the compactor-single-binary branch from bea7698 to 1b9059e Compare January 25, 2022 08:45
…d examples to enable compactor sharding.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…sabled.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany force-pushed the compactor-single-binary branch from 1b9059e to 41378cc Compare January 25, 2022 08:55
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM! I just left a nit.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany merged commit 5270b17 into main Jan 25, 2022
@pstibrany pstibrany deleted the compactor-single-binary branch January 25, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants