Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default server.http-listen-port to 8080 #871

Merged
merged 10 commits into from
Jan 26, 2022
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@
* `-distributor.sharding-strategy` option has been removed, and shuffle sharding is enabled by default. Default shard size is set to 0, which disables shuffle sharding for the tenant (all ingesters will receive tenants's samples). #888
* `-ruler.sharding-strategy` option has been removed from ruler. Ruler now uses shuffle-sharding by default, but respects `ruler_tenant_shard_size`, which defaults to 0 (ie. use all rulers for tenant). #889
* `-store-gateway.sharding-strategy` option has been removed store-gateways. Store-gateway now uses shuffle-sharding by default, but respects `store_gateway_tenant_shard_size` for tenant, and this value defaults to 0. #891
* [CHANGE] Server: `-server.http-listen-port` (yaml: `server.http_listen_port`) now defaults to `8080` (previously `80`). #871
* [FEATURE] Query Frontend: Add `cortex_query_fetched_chunks_total` per-user counter to expose the number of chunks fetched as part of queries. This metric can be enabled with the `-frontend.query-stats-enabled` flag (or its respective YAML config option `query_stats_enabled`). #31
* [FEATURE] Query Frontend: Add experimental querysharding for the blocks storage (instant and range queries). You can now enable querysharding for blocks storage (`-store.engine=blocks`) by setting `-frontend.parallelize-shardable-queries` to `true`. The following additional config and exported metrics have been added. #79 #80 #100 #124 #140 #148 #150 #151 #153 #154 #155 #156 #157 #158 #159 #160 #163 #169 #172 #196 #205 #225 #226 #227 #228 #230 #235 #240 #239 #246 #244 #319 #330 #371 #385 #400 #458 #586 #630 #660 #707
* New config options:
Expand Down
2 changes: 1 addition & 1 deletion cmd/mimir/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ARG BINARY_SUFFIX="_${TARGETOS}_${TARGETARCH}"
# Set to non-empty value to use ${TARGET_SUFFIX} when copying mimir binary, leave unset to use no suffix.
ARG USE_BINARY_SUFFIX
COPY mimir${USE_BINARY_SUFFIX:+${BINARY_SUFFIX}} /bin/mimir
EXPOSE 80
EXPOSE 8080
ENTRYPOINT [ "/bin/mimir" ]

ARG revision
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/configuration/config-file-reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ The `server_config` configures the HTTP and gRPC server of the launched service(

# HTTP server listen port.
# CLI flag: -server.http-listen-port
[http_listen_port: <int> | default = 80]
[http_listen_port: <int> | default = 8080]

# Maximum number of simultaneous http connections, <=0 to disable
# CLI flag: -server.http-conn-limit
Expand Down
4 changes: 2 additions & 2 deletions docs/sources/operations/requests-mirroring-envoy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ static_resources:
- name: cortex_primary
type: STRICT_DNS
connect_timeout: 1s
hosts: [{ socket_address: { address: cortex-primary, port_value: 80 }}]
hosts: [{ socket_address: { address: cortex-primary, port_value: 8080 }}]
dns_refresh_rate: 5s
- name: cortex_secondary
type: STRICT_DNS
connect_timeout: 1s
hosts: [{ socket_address: { address: cortex-secondary, port_value: 80 }}]
hosts: [{ socket_address: { address: cortex-secondary, port_value: 8080 }}]
dns_refresh_rate: 5s
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ For example, requests mirroring can be used when you need to setup a testing Cor

### Example Envoy config

The following Envoy configuration shows an example with two Cortex clusters. Envoy will listen on port `9900` and will proxies all requests to `cortex-primary:80`, mirroring it to `cortex-secondary:80` too.
The following Envoy configuration shows an example with two Cortex clusters. Envoy will listen on port `9900` and will proxies all requests to `cortex-primary:8080`, mirroring it to `cortex-secondary:8080` too.

<!-- prettier-ignore-start -->
[embedmd]:# (./requests-mirroring-envoy.yaml)
Expand Down Expand Up @@ -62,12 +62,12 @@ static_resources:
- name: cortex_primary
type: STRICT_DNS
connect_timeout: 1s
hosts: [{ socket_address: { address: cortex-primary, port_value: 80 }}]
hosts: [{ socket_address: { address: cortex-primary, port_value: 8080 }}]
dns_refresh_rate: 5s
- name: cortex_secondary
type: STRICT_DNS
connect_timeout: 1s
hosts: [{ socket_address: { address: cortex-secondary, port_value: 80 }}]
hosts: [{ socket_address: { address: cortex-secondary, port_value: 8080 }}]
dns_refresh_rate: 5s
```
<!-- prettier-ignore-end -->
1 change: 1 addition & 0 deletions integration/backward_compatibility.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package integration
var DefaultPreviousVersionImages = map[string]func(map[string]string) map[string]string{
"quay.io/cortexproject/cortex:v1.11.0": func(flags map[string]string) map[string]string {
flags["-store.engine"] = "blocks"
flags["-server.http-listen-port"] = "8080"
return flags
},
}
2 changes: 1 addition & 1 deletion integration/e2emimir/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
)

const (
httpPort = 80
httpPort = 8080
grpcPort = 9095
GossipPort = 9094
)
Expand Down
Loading