Fix TestBlocksCleaner_ShouldRemoveBlocksOutsideRetentionPeriod flakyness #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
I've submitted a fix to Thanos (PR 5103). Let's see if it gets merged quickly. If so, we can just upgrade Thanos and keep blocks deletion concurrency in our unit tests (which would be better so we exercise that code too). |
|
Let's merge this, since it's failing quite frequently in CI. I will rollback once Thanos PR is merged. |
pracucci
deleted the
fix-TestBlocksCleaner_ShouldRemoveBlocksOutsideRetentionPeriod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
TestBlocksCleaner_ShouldRemoveBlocksOutsideRetentionPeriod(like other tests) uses the filesystem-based object store. I found this suffers a race condition in the deletion of an empty dir: basically, if 2 goroutines delete an object in the same folder at the same time and, after their deletion, both of them detect that the dir is empty, the 2nd one trying to delete the empty dir will return error.I will submit a fix to Thanos, but in the meanwhile I suggest to disable the blocks deletion concurrency in our tests.
Which issue(s) this PR fixes:
Fixes #824
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]