Ensure native histograms counter reset hints are corrected when merging results from different sources #9909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
reviewed
Nov 15, 2024
fionaliao
force-pushed
the
fl/counter-resets-ooonh
branch
from
18d9cf2
to
d9c34a7
Compare
fionaliao
requested review from
stevesg,
grafanabot and
a team
as code owners
|
Implementation and testing is done (pending CI), but I want to extract the mimir-prometheus update into a separate PR before removing the "WIP" |
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
fionaliao
force-pushed
the
fl/counter-resets-ooonh
branch
from
7b27917
to
0f4f294
Compare
fionaliao
changed the title
|
mimir-prometheus update was done as part of #10033 |
fionaliao
force-pushed
the
fl/counter-resets-ooonh
branch
from
e7d5fb6
to
24bea3c
Compare
fionaliao
commented
Nov 27, 2024
krajorama
reviewed
Nov 28, 2024
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
fionaliao
changed the title
krajorama
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When merging samples from different iterators, histogram counter reset hints need to be recalculated. The
mergeIteratorcurrently does not do so. This PR fixes that by remembering the iterator for a sample in a batch, so when the next sample comes along, the iterators for the two samples can be compared and an unknown counter reset hint is set for the next sample if the iterators don't match. See prometheus/prometheus#15346 for related discussion.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.