Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pruning middleware before query sharding middleware #9913

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

zenador
Copy link
Contributor

@zenador zenador commented Nov 15, 2024

What this PR does

Moves pruning middleware to earlier in the flow, before query sharding middleware instead of after, as it makes more sense to do it earlier.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@zenador zenador requested a review from a team as a code owner November 15, 2024 05:14
@zenador zenador requested a review from charleskorn November 15, 2024 05:17
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nit

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
@zenador zenador enabled auto-merge (squash) November 15, 2024 06:01
@zenador zenador merged commit ee4fee0 into main Nov 15, 2024
29 checks passed
@zenador zenador deleted the zenador/prune-earlier branch November 15, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants