-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable free-text searching on alert groups #2232
Comments
The current version of Grafana OnCall, at the time this issue was opened, is v1.2.43. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄! |
Hello @joeyorlando @Matvey-Kuk I hope this message finds you well. Could I kindly inquire if there is an estimated timeline for addressing the issue at hand? It appears that the search functionality, which seems to be a fundamental feature, has been non-operational for over a year. I was wondering if, pending the resolution of the performance issues, it might be feasible to introduce a setting that allows those who require the search function to enable it temporarily. Thank you |
this is not on the core team's short term roadmap. I provided a workaround here to have this feature enabled under a feature flag. If you're keen to open a pull request we can certainly review 🙂 |
thanks! |
@joeyorlando |
The plugin replace the entered value to null for the "search" field in this place. |
@fantom0005 thanks, I renamed the search field and the search started working |
@sreway Can you share your solution? |
Same issue |
# What this PR does re-enables the search for alert groups ## Which issue(s) this PR closes Closes #2232 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com> Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
# What this PR does re-enables the search for alert groups ## Which issue(s) this PR closes Closes #2232 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com> Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
#2098 and #2101 temporarily disabled it.
We should re-enable searching here, but ensure that the proper indices are added and that it works with large amounts of alert groups.
The text was updated successfully, but these errors were encountered: