Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a Slack DM when user is not in channel #1144

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

vadimkerr
Copy link
Member

@vadimkerr vadimkerr commented Jan 17, 2023

What this PR does

Currently, when a user gets mentioned in an alert group thread and the user is not in the Slack channel, the Slack bot sends the following to the channel:

⚠️ Tried to ask USER to look at incident. Unfortunately USER is not in this channel. Please, invite.

This PR changes this behaviour to instead send a direct message to the user. The message contains a link to the main alert group message in Slack.

Screenshot 2023-01-17 at 19 25 36

Checklist

  • Tests updated (N/A)
  • Documentation added (N/A)
  • CHANGELOG.md updated

@vadimkerr vadimkerr requested a review from a team January 17, 2023 19:50
@vadimkerr vadimkerr merged commit c93ee5c into dev Jan 18, 2023
@vadimkerr vadimkerr deleted the vadimkerr/slack-dm-alerts branch January 18, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants