Rares/score quality #1324
Merged
Rares/score quality #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
added
the
pr:no public docs
|
it could be worthwhile adding some notes about the schedule quality metrics to our public docs |
|
I agree with Joey about documentation |
maskin25
approved these changes
Mar 13, 2023
| <Text type="secondary">{tooltipContent}</Text> | ||
| </VerticalGroup> | ||
| </div> | ||
| } | ||
| > | ||
| <div className={cx('root', { [`root__type_${type}`]: true })} onMouseEnter={onHover}> | ||
| <div className={cx('root', { [`root__type_${type}`]: true }, { padding: addPadding })} onMouseEnter={onHover}> |
There was a problem hiding this comment.
minor: 'add-padding': addPadding naming looks better because it's clear that it's boolean
|
|
||
| const [expanded, setExpanded] = useState<boolean>(false); | ||
| {schedule.warnings?.length > 0 && ( |
There was a problem hiding this comment.
can schedule be null/undefined here?
There was a problem hiding this comment.
No, if it's undefined then we do not render ScheduleQuality
| return null; | ||
| } | ||
|
|
||
| const infoComments = comments.filter((c) => c.type === 'info'); |
There was a problem hiding this comment.
useMemo here and below looks more reactish but doesn't make sense a lot
There was a problem hiding this comment.
useMemo seems an overkill, it's a trivial JSON data, a few comments at most.
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does #118 ## Checklist - [x] Tests updated - [ ] Documentation added - [x] `CHANGELOG.md` updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
#118
Checklist
CHANGELOG.mdupdated