Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule quality backend improvements #1461

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Schedule quality backend improvements #1461

merged 4 commits into from
Mar 6, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 6, 2023 •
edited
Loading

What this PR does

Changes the schedule quality API so it also returns types of comments (this is needed to address #118 (comment)).

Which issue(s) this PR fixes

Related to #118

Checklist

  • Tests updated

@vstpme vstpme added pr:no changelog pr:no public docs Added to a PR that does not require public documentation updates labels Mar 6, 2023
@vstpme vstpme marked this pull request as ready for review March 6, 2023 14:03
@vstpme vstpme requested a review from a team March 6, 2023 14:03
@vstpme vstpme enabled auto-merge March 6, 2023 14:04
matiasb
matiasb approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor suggestion

engine/apps/schedules/quality_score.py Outdated Show resolved Hide resolved
@vstpme vstpme added this pull request to the merge queue Mar 6, 2023
@vstpme vstpme removed this pull request from the merge queue due to a manual request Mar 6, 2023
@vstpme vstpme enabled auto-merge March 6, 2023 14:20
@vstpme vstpme added this pull request to the merge queue Mar 6, 2023
Merged via the queue into dev with commit ab493de Mar 6, 2023
@vstpme vstpme deleted the vadimkerr/schedule-quality-improvements branch March 6, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb