Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warnings on users page in a clean and consistent way #1681

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Display warnings on users page in a clean and consistent way #1681

merged 4 commits into from
Apr 3, 2023

Conversation

iskhakov
Copy link
Contributor

What this PR does

Before:
Screenshot 2023-03-31 at 10 00 25

After:
Screenshot 2023-03-31 at 09 59 22

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team March 31, 2023 02:00
@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 31, 2023
teodosii
teodosii approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@teodosii teodosii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Looks good.

joeyorlando
joeyorlando approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

@iskhakov iskhakov added this pull request to the merge queue Apr 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2023
@iskhakov iskhakov merged commit 5329961 into dev Apr 3, 2023
@iskhakov iskhakov deleted the iskhakov/users-table-cleanup branch April 3, 2023 10:19
brojd pushed a commit that referenced this pull request Sep 18, 2024
@iskhakov
Display warnings on users page in a clean and consistent way (#1681)
980ac07 
# What this PR does

Before:
<img width="942" alt="Screenshot 2023-03-31 at 10 00 25"
src="https://user-images.githubusercontent.com/2262529/229003826-1f42820f-6997-4fec-82ed-acf4355b6758.png">


After:
<img width="937" alt="Screenshot 2023-03-31 at 09 59 22"
src="https://user-images.githubusercontent.com/2262529/229003723-6ac1743d-316f-4272-a73a-a1bebb27618f.png">


## Which issue(s) this PR fixes


## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodosii teodosii teodosii approved these changes

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskhakov @joeyorlando @teodosii