Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new field description_short to private and public api #1698

Merged
merged 16 commits into from
Apr 18, 2023
Merged

Add new field description_short to private and public api #1698

merged 16 commits into from
Apr 18, 2023

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Apr 4, 2023 •
edited
Loading

What this PR does

Required for new Integrations page
Screenshot 2023-04-04 at 20 32 03

Examples:

curl 'http://localhost:3000/api/plugin-proxy/grafana-oncall-app/api/internal/v1/alert_receive_channels/' \
  -H 'Content-Type: application/json' \
  --data-raw '{"description_short": "aaaaaaaaaaaaaaaaaaaa", "integration":"formatted_webhook","team":null}' \
  --compressed

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team April 4, 2023 12:30
@iskhakov iskhakov changed the title Add new field description_short to private api Add new field description_short to private and public api Apr 4, 2023
@iskhakov iskhakov marked this pull request as draft April 4, 2023 13:40
@iskhakov iskhakov self-assigned this Apr 12, 2023
@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Apr 14, 2023
@iskhakov iskhakov marked this pull request as ready for review April 14, 2023 05:15
joeyorlando
joeyorlando approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@iskhakov iskhakov changed the title Add new field description_short to private and public api [READY] Add new field description_short to private and public api Apr 17, 2023
@iskhakov iskhakov changed the title [READY] Add new field description_short to private and public api [Ready] Add new field description_short to private and public api Apr 17, 2023
@iskhakov iskhakov changed the title [Ready] Add new field description_short to private and public api Add new field description_short to private and public api Apr 18, 2023
@iskhakov iskhakov enabled auto-merge April 18, 2023 02:44
@iskhakov iskhakov added this pull request to the merge queue Apr 18, 2023
Merged via the queue into dev with commit cee0fdc Apr 18, 2023
@iskhakov iskhakov deleted the iskhakov/add-short-description-to-integration branch April 18, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees

@iskhakov iskhakov

Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskhakov @joeyorlando