Unify "name" and "title" field for oncall shift #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Konstantinov-Innokentii
added
pr:no changelog
pr:no public docs
Ferril
reviewed
Apr 27, 2023
Ferril
reviewed
Apr 27, 2023
Ferril
reviewed
Apr 27, 2023
Konstantinov-Innokentii
force-pushed
the
unify_shift_name
branch
from
6000496
to
1ecd289
Compare
# Conflicts: # engine/apps/api/views/alert_group.py
Ferril
approved these changes
May 17, 2023
|
merged in maxim/1502-visualize-schedule-weekends branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It drops "title" field from OnCall shift and makes "name" field not-required and nullable. It is needed to provide ability to change shift name in web ui.
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)