Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove schedule name uniqueness restriction #1859

Merged
merged 2 commits into from
May 2, 2023
Merged

Remove schedule name uniqueness restriction #1859

merged 2 commits into from
May 2, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented May 2, 2023

Related to #1452

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label May 2, 2023
@matiasb matiasb force-pushed the matiasb/schedule-name-non-unique branch from 7ccac8d to d937e17 Compare May 2, 2023 13:26
@matiasb matiasb marked this pull request as ready for review May 2, 2023 13:54
@matiasb matiasb requested a review from a team May 2, 2023 13:54
vadimkerr
vadimkerr approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@vadimkerr vadimkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
nit: maybe add a simple unit test creating two schedules with the same name?

engine/apps/schedules/migrations/0012_auto_20230502_1259.py Show resolved Hide resolved
@matiasb matiasb added this pull request to the merge queue May 2, 2023
Merged via the queue into dev with commit ad39bbf May 2, 2023
@matiasb matiasb deleted the matiasb/schedule-name-non-unique branch May 2, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderynck mderynck mderynck approved these changes

@vadimkerr vadimkerr vadimkerr approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiasb @vadimkerr @mderynck