Show 100000+ in stats when there are more than 100000 alert groups in the result #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
commented
May 10, 2023
engine/apps/api/views/alert_group.py
Outdated
| @@ -398,20 +398,14 @@ def enrich(self, alert_groups): | |||
|
|
|||
| @action(detail=False) | |||
| def stats(self, *args, **kwargs): | |||
| alert_groups = self.filter_queryset(self.get_queryset()) | |||
| # Only count field is used, other fields left just in case for the backward compatibility | |||
| MAX_COUNT = 1001 | |||
There was a problem hiding this comment.
TODO: define this number
iskhakov
commented
May 10, 2023
| # Only count field is used, other fields left just in case for the backward compatibility | ||
| MAX_COUNT = 1001 | ||
| alert_groups = self.filter_queryset(self.get_queryset())[:MAX_COUNT] | ||
| count = alert_groups.count() |
There was a problem hiding this comment.
TODO: check if we need to use len() here
joeyorlando
reviewed
May 14, 2023
Comment on lines
-405
to
-416
| "count": alert_groups.filter().count(), | ||
| "count_previous_same_period": 0, | ||
| "alert_group_rate_to_previous_same_period": 1, | ||
| "count_escalations": 0, | ||
| "count_escalations_previous_same_period": 0, | ||
| "escalation_rate_to_previous_same_period": 1, | ||
| "average_response_time": None, | ||
| "average_response_time_to_previous_same_period": None, | ||
| "average_response_time_rate_to_previous_same_period": 0, | ||
| "prev_period_in_days": 1, |
joeyorlando
reviewed
May 14, 2023
engine/apps/api/views/alert_group.py
Outdated
| MAX_COUNT = 1001 | ||
| alert_groups = self.filter_queryset(self.get_queryset())[:MAX_COUNT] | ||
| count = alert_groups.count() | ||
| print(count) |
joeyorlando
approved these changes
May 14, 2023
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
joeyorlando
added
pr:stale
github-actions
bot
removed
the
pr:stale
iskhakov
added
the
pr:no public docs
iskhakov
changed the title
iskhakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)