Fix MultipleObjectsReturned error on webhook endpoints #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkerr
added
the
pr:no public docs
vadimkerr
changed the title
vadimkerr
changed the title
matiasb
approved these changes
May 23, 2023
# Conflicts: # CHANGELOG.md
joeyorlando
reviewed
May 23, 2023
Comment on lines
+200
to
+203
| """ | ||
| This property returns a list of Q objects that are used to filter instances by teams available to the user. | ||
| NOTE: use .distinct() after filtering by available teams as it may return duplicate instances. | ||
| """ |
vadimkerr
added a commit
that referenced
this pull request
May 24, 2023
# What this PR does Sometimes `CustomButtonView` returns HTTP 500 with the following error: ``` apps.alerts.models.custom_button.CustomButton.MultipleObjectsReturned: get() returned more than one CustomButton -- it returned 3! ``` This PR fixes it by adding `.distinct()` to the `CustomButton` queryset when retrieving an instance + does the same for `WebhooksView`. ## Which issue(s) this PR fixes Related to grafana/oncall-private#1828 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Sometimes
CustomButtonViewreturns HTTP 500 with the following error:This PR fixes it by adding
.distinct()to theCustomButtonqueryset when retrieving an instance + does the same forWebhooksView.Which issue(s) this PR fixes
Related to https://github.com/grafana/oncall-private/issues/1828
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)