Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error when updating closed modal window in Slack #2019

Merged
merged 2 commits into from
May 25, 2023

Conversation

vadimkerr
Copy link
Member

@vadimkerr vadimkerr commented May 25, 2023

What this PR does

Handle HTTP 500 error when attempting to update resolution note modal window that was already closed by user.

Which issue(s) this PR fixes

Related to https://github.com/grafana/oncall-private/issues/1834

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vadimkerr vadimkerr added the pr:no public docs Added to a PR that does not require public documentation updates label May 25, 2023
@vadimkerr vadimkerr marked this pull request as ready for review May 25, 2023 09:54
@vadimkerr vadimkerr requested a review from a team May 25, 2023 09:54
@joeyorlando joeyorlando added this pull request to the merge queue May 25, 2023
Merged via the queue into dev with commit 12061a2 May 25, 2023
@joeyorlando joeyorlando deleted the vadimkerr/slack-fix-500-on-closed-modal branch May 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants