TwilioPhoneProvider optimizations #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konstantinov-Innokentii
added
pr:no changelog
pr:no public docs
Konstantinov-Innokentii
changed the title
iskhakov
approved these changes
Jun 1, 2023
| status_code = TwilioCallStatuses.DETERMINANT.get(call_status) | ||
|
|
||
| if status_code is None: | ||
| logger.warning( |
There was a problem hiding this comment.
how normal is receiving unexpected status? This code won't alert us if we start receiving unexpected statuses
There was a problem hiding this comment.
It's ok, status is only needed for better timeline. The thing about checking status always was in twilio part, so I decided to at least log it
| @@ -61,12 +61,10 @@ def _calculate_phone_notifications_left(self, user): | |||
| day_start = now.replace(hour=0, minute=0, second=0, microsecond=0) | |||
| calls_today = PhoneCallRecord.objects.filter( | |||
| created_at__gte=day_start, | |||
| represents_alert_group__channel__organization=self.organization, | |||
There was a problem hiding this comment.
we remove it because user can be a member of single organization and organization filter is excess, isn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR does three improvements in twilio_phone_provider: