Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SlackActionRecord model/table #2201

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

joeyorlando
Copy link
Contributor

What this PR does

Closes #2169

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Jun 13, 2023
@joeyorlando joeyorlando requested a review from a team June 13, 2023 09:02
@@ -59,7 +58,8 @@ services:
- ./grafana-plugin:/etc/app
- node_modules_dev:/etc/app/node_modules
# https://stackoverflow.com/a/60456034
- ${ENTERPRISE_FRONTEND:-/dev/null}:/etc/app/frontend_enterprise
# see the explaination above that uses the $ENTERPRISE_ENGINE env var
- ${ENTERPRISE_FRONTEND:-/dev/null}:${ENTERPRISE_FRONTEND_VOLUME_MOUNT_DEST_DIR:-/tmp/empty:ro}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating this because I got this locally:

Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/dev/null" to rootfs at "/etc/app/frontend_enterprise": mount /dev/null:/etc/app/frontend_enterprise (via /proc/self/fd/9), flags: 0x5000: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
make: *** [start] Error 1

See the oncall-private change here related to this

@joeyorlando joeyorlando added this pull request to the merge queue Jun 13, 2023
Merged via the queue into dev with commit 90e0b21 Jun 13, 2023
@joeyorlando joeyorlando deleted the jorlando/remove-slack-action-record branch June 13, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove SlackActionRecord model/table
3 participants