Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of grafana feature flags that're enabled via the feature_toggles.enabled syntax #2477

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

joeyorlando
Copy link
Contributor

What this PR does

Grafana provides two methods for enabling feature flags:

  • feature_toggles.enabled
  • feature_toggles.<name_of_feature_flag>

For example, to enable accessControlOnCall you could either do:

{
  "feature_toggles": {
    "enabled": "accessControlOnCall,someOtherCoolFeatureFlag"
  }
}

or:

{
  "feature_toggles": {
    "accessControlOnCall": true,
    "someOtherCoolFeatureFlag": true
  }
}

In method 1, if they're multiple feature flags present, they are comma separated, not space separated. This PR fixes this parsing issue.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required) (N/A)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

enabled via the feature_toggles.enabled
syntax
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 10, 2023
@joeyorlando joeyorlando requested a review from a team July 10, 2023 08:14
@joeyorlando joeyorlando merged commit 182f18d into dev Jul 10, 2023
@joeyorlando joeyorlando deleted the jorlando/fix-grafana-feature-toggle-parsing branch July 10, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants